[Webkit-unassigned] [Bug 231101] [WinCairo] Support run-jsc-stress-tests without posix commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231101

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #440092|review?                     |review-
              Flags|                            |

--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 440092
  --> https://bugs.webkit.org/attachment.cgi?id=440092
Patch

Hello, and thanks for the patch. I think this is going in the right
direction, but I have a couple of suggestions to make it even better.
Please read on below :)

View in context: https://bugs.webkit.org/attachment.cgi?id=440092&action=review

> Tools/Scripts/run-jsc-stress-tests:2334
> +    def each_line

I suppose this function could be just a function; there is no
need to put it inside a class, right?

> Tools/Scripts/run-jsc-stress-tests:2367
> +            statusFileEnumerator.each_line {

I would completely remove the usage of the “find” command and use the
same code that uses Ruby functions to locate and read the result files.
The advantages would be having only one code path to maintain that works
for all ports, and avoiding spawning a bunch of subprocesses here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211005/02460416/attachment.htm>