[Webkit-unassigned] [Bug 231101] [WinCairo] Support run-jsc-stress-tests without posix commands

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 5 14:43:40 PDT 2021


--- Comment #7 from Stephan Szabo <stephan.szabo at sony.com> ---
(In reply to Adrian Perez from comment #6)
> Comment on attachment 440092 [details]
> Patch
> Hello, and thanks for the patch. I think this is going in the right
> direction, but I have a couple of suggestions to make it even better.
> Please read on below :)
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440092&action=review
> > Tools/Scripts/run-jsc-stress-tests:2334
> > +    def each_line
> I suppose this function could be just a function; there is no
> need to put it inside a class, right?

Hmm, probably. Ruby isn't high on my list of languages, so I figured that it was suggested as a class to make it look similar to the popen output. If we don't switch between them per the below, then even the function might not be strictly necessary.

> > Tools/Scripts/run-jsc-stress-tests:2367
> > +            statusFileEnumerator.each_line {
> I would completely remove the usage of the “find” command and use the
> same code that uses Ruby functions to locate and read the result files.
> The advantages would be having only one code path to maintain that works
> for all ports, and avoiding spawning a bunch of subprocesses here.

I'd thought about that, but I wasn't sure how to best manage that with the $remote codepath and was concerned that it might be wanted to keep the same code between the local non-windows and remote case, but I can change either way.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211005/2af190b3/attachment.htm>

More information about the webkit-unassigned mailing list