[Webkit-unassigned] [Bug 232622] [GTK][a11y] Embedded objects are not correctly handled by text interface with ATSPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232622

--- Comment #3 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Carlos Garcia Campos from comment #2)
> Created attachment 443088 [details]
> Patch

--- a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
+++ a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
@@ -2145,7 +2145,12 @@ VisiblePosition AccessibilityRenderObject::visiblePositionForIndex(int index) co
     if (!node)
         return VisiblePosition();

+#if USE(ATSPI)
+    // We need to consider replaced elements for GTK, as they will be presented with the 'object replacement character' (0xFFFC).
+    return { makeDeprecatedLegacyPosition(resolveCharacterLocation(makeRangeSelectingNodeContents(*node), index, TextIteratorBehavior::EmitsObjectReplacementCharacters)) };

Can we use 

VisiblePosition visiblePositionForIndex(int index, ContainerNode* scope)

in editing.cpp adding a TextIteratorBehaviors parameter to it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211104/0dffddad/attachment-0001.htm>