[Webkit-unassigned] [Bug 232622] [GTK][a11y] Embedded objects are not correctly handled by text interface with ATSPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232622

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Andres Gonzalez from comment #3)
> (In reply to Carlos Garcia Campos from comment #2)
> > Created attachment 443088 [details]
> > Patch
> 
> --- a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
> +++ a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
> @@ -2145,7 +2145,12 @@ VisiblePosition
> AccessibilityRenderObject::visiblePositionForIndex(int index) co
>      if (!node)
>          return VisiblePosition();
> 
> +#if USE(ATSPI)
> +    // We need to consider replaced elements for GTK, as they will be
> presented with the 'object replacement character' (0xFFFC).
> +    return {
> makeDeprecatedLegacyPosition(resolveCharacterLocation(makeRangeSelectingNodeC
> ontents(*node), index,
> TextIteratorBehavior::EmitsObjectReplacementCharacters)) };
> 
> Can we use 
> 
> VisiblePosition visiblePositionForIndex(int index, ContainerNode* scope)
> 
> in editing.cpp adding a TextIteratorBehaviors parameter to it?

That was my initial idea, but it expects ContainerNode while we have just a Node and I'm not sure it's ok to change visiblePositionForIndex to receive a Node.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211104/86cb6dae/attachment.htm>