[Webkit-unassigned] [Bug 225800] [MSE] MediaSample that need to be removed with SourceBufferPrivate::evictCodedFrames() may not be removed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225800

--- Comment #8 from Toshio Ogasawara <toshio.ogasawara at access-company.com> ---
(In reply to Jer Noble from comment #7)
> (In reply to Jer Noble from comment #6)
> > -    MediaTime minimumRangeStart = currentTime + thirtySeconds;
> > +    MediaTime minimumRangeStart = std::min(currentTime + thirtySeconds,
> > buffered.end(currentTimeRange));
> 
> Whoops, this should be max, not min.
> 
> (In reply to Toshio Ogasawara from comment #4)
> > I think it is correct to compare the end of the range(rangeEnd) when
> > processing in descending order, and the start of the range(startRange) when
> > processing in ascending order.
> 
> I take back my earlier comment, you're right about this comparison, because
> rangeStart isn't actually used inside the loop without doing
> `max(minimumRangeStart, rangeStart)` first.
> 
> Still, the entire first section of the while() loop can be removed to solve
> this problem, rather than adding more calculations.

I was able to confirm with your fix that minimumRangeStart is set to be correctly placed at the end of the current range, or 30 seconds after the currentTime, whichever is higher.
Now we don't need to do complicated recalculation.
Thank you.


> Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:703
> -    while (rangeStart > minimumRangeStart) {
> +    while (rangeEnd > minimumRangeStart) {
I will add this fix to take into account the following conditions.

When "rangeStart < minimumRangeStart, rangeEnd > minimumRangeStart", remove between minimumRangeStart and rangeEnd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210526/5ee05a14/attachment-0001.htm>