[Webkit-unassigned] [Bug 225800] [MSE] MediaSample that need to be removed with SourceBufferPrivate::evictCodedFrames() may not be removed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225800

--- Comment #7 from Jer Noble <jer.noble at apple.com> ---
(In reply to Jer Noble from comment #6)
> -    MediaTime minimumRangeStart = currentTime + thirtySeconds;
> +    MediaTime minimumRangeStart = std::min(currentTime + thirtySeconds,
> buffered.end(currentTimeRange));

Whoops, this should be max, not min.

(In reply to Toshio Ogasawara from comment #4)
> I think it is correct to compare the end of the range(rangeEnd) when
> processing in descending order, and the start of the range(startRange) when
> processing in ascending order.

I take back my earlier comment, you're right about this comparison, because rangeStart isn't actually used inside the loop without doing `max(minimumRangeStart, rangeStart)` first.

Still, the entire first section of the while() loop can be removed to solve this problem, rather than adding more calculations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210521/894eab07/attachment-0001.htm>