[Webkit-unassigned] [Bug 225941] WKRemoteObjectRegistry _invokeMethod needs to check for nil completionHandlers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225941

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cdumez at apple.com
 Attachment #429105|review?                     |review+
              Flags|                            |

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 429105
  --> https://bugs.webkit.org/attachment.cgi?id=429105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429105&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:51
> +    BOOL didCallSayHello = NO;

Don't we usually have curly brackets around the data members?

@implementation IPCTestingAPIDelegate {
    BOOL didCallSayHello;
}

Also, I don't believe we need the NO initializer in ObjC.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:161
> +    EXPECT_EQ([delegate.get() sayHelloWasCalled], NO);

EXPECT_FALSE([delegate.get() sayHelloWasCalled]);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210520/84cb94c3/attachment.htm>