[Webkit-unassigned] [Bug 225941] WKRemoteObjectRegistry _invokeMethod needs to check for nil completionHandlers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 15:26:20 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=225941

--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 429105
  --> https://bugs.webkit.org/attachment.cgi?id=429105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429105&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:51
>> +    BOOL didCallSayHello = NO;
> 
> Don't we usually have curly brackets around the data members?
> 
> @implementation IPCTestingAPIDelegate {
>     BOOL didCallSayHello;
> }
> 
> Also, I don't believe we need the NO initializer in ObjC.

(and a leading underscore)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210520/ea3f79af/attachment.htm>


More information about the webkit-unassigned mailing list