[Webkit-unassigned] [Bug 226986] Refactor MacOS keyboard scrolling and use KeyboardScroll struct

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226986

--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 431719
  --> https://bugs.webkit.org/attachment.cgi?id=431719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431719&action=review

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:461
> +    // // First give accessibility a chance to handle the event.
> +    // Frame* frame = frameForEvent(event);
> +    // frame->eventHandler().handleKeyboardSelectionMovementForAccessibility(*event);
> +    // if (event->defaultHandled())
> +    //     return true;

Probably need to leave THIS code alone.

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:468
> +    // if (selector == "moveUp:")

Instead of leaving these commented out, I think you should add an off-by-default (until you're further along) setting (see WebPreferences*.yaml) or maybe a compile-time flag (see PlatformEnable.h); here you'll use it to guard the ones you don't want to be evaluated as "non-editing editing command behaviors" anymore, and will bail in EventHandler::handleKeyboardScrolling.

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:487
> +    // else if (selector == "moveToLeftEndOfLine:")
> +    //     didPerformAction = m_userInterfaceLayoutDirection == WebCore::UserInterfaceLayoutDirection::LTR ? m_page->backForward().goBack() : m_page->backForward().goForward();

For now, you've not moved goForward/goBack, so need to put this one back

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:493
> +    //     didPerformAction = m_userInterfaceLayoutDirection == WebCore::UserInterfaceLayoutDirection::LTR ? m_page->backForward().goForward() : m_page->backForward().goBack();

For now, you've not moved goForward/goBack, so need to put this one back

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210617/6121fb27/attachment-0001.htm>