[Webkit-unassigned] [Bug 226986] Refactor MacOS keyboard scrolling and use KeyboardScroll struct

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226986

--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 431719
  --> https://bugs.webkit.org/attachment.cgi?id=431719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431719&action=review

> Source/WebCore/page/EventHandler.cpp:4244
> +const WebCore::KeyboardScrollParameters& EventHandler::parameters()
> +{
> +    static const KeyboardScrollParameters parameters;
> +    return parameters;
> +}

I think KeyboardScrollParameters could maybe hang on a static method off KeyboardScroll? EventHandler is not the right place, anyway

> Source/WebCore/page/EventHandler.h:379
> +

Too many newlines around this paragraph

> Source/WebCore/page/EventHandler.h:380
> +    const WebCore::KeyboardScrollParameters& parameters();

Not sure why this is here. Don't think it needs to be.

> Source/WebCore/page/KeyboardScroll.h:34
> +enum class ScrollingIncrement : uint8_t {
> +    Line,
> +    Page,
> +    Document
> +};

Instead of this, you should just make all this code use ScrollTypes.h's ScrollGranularity

> Source/WebCore/page/KeyboardScroll.h:41
> +enum class ScrollingDirection : uint8_t {
> +    Up,
> +    Down,
> +    Left,
> +    Right
> +};

Instead of this, you should just make all this code use ScrollTypes.h's ScrollDirection

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:783
> +    

Should be able to revert this and not touch this file at all :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210617/8f3103b1/attachment.htm>