[Webkit-unassigned] [Bug 226530] Style::Scope should use CheckedPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226530

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 430333
  --> https://bugs.webkit.org/attachment.cgi?id=430333
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430333&action=review

>> Source/WebCore/style/StyleScope.cpp:671
>> +        resolverScopes.add(makeRef(*resolver), Vector<CheckedPtr<Scope>> { }).iterator->value.append(&scope);
> 
> You add an empty vector, and append a single Scope.
> Does this vector always have only a single Scope?
> If so, why is ResolverScopes's ValueType using Vector<CheckedPtr<Scope>>?

We're in a loop so we may add more scope than one to the Vector. (Note that add() is a no-op if the key already exists)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210602/d6c44b8f/attachment.htm>