[Webkit-unassigned] [Bug 226530] Style::Scope should use CheckedPtr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 2 14:12:15 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=226530

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Hironori.Fujii at sony.com

--- Comment #5 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 430333
  --> https://bugs.webkit.org/attachment.cgi?id=430333
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430333&action=review

> Source/WebCore/style/StyleScope.cpp:671
> +        resolverScopes.add(makeRef(*resolver), Vector<CheckedPtr<Scope>> { }).iterator->value.append(&scope);

You add an empty vector, and append a single Scope.
Does this vector always have only a single Scope?
If so, why is ResolverScopes's ValueType using Vector<CheckedPtr<Scope>>?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210602/c2f6719f/attachment.htm>


More information about the webkit-unassigned mailing list