[Webkit-unassigned] [Bug 228308] [WinCairo] New GraphicsLayer for GPU process mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228308

--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 434501
  --> https://bugs.webkit.org/attachment.cgi?id=434501
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434501&action=review

>> Source/WebCore/svg/graphics/SVGImage.cpp:283
>> +#if !USE(WC) // This code path causes incorrect SVG rendering
> 
> Please don't add platform #ifdefs in shared files. If this is wrong, we should figure out how to make it work. Perhaps `!context.hasPlatformContext()` is the wrong check.

Yup. I should debug the SVG image issue or wait Myles to fix Bug#227748.

>> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:146
>> +#if USE(WC)
> 
> "WC" is too short an acronym to be understandable. Please choose something longer.

Doesn't it match with USE(CA) and GraphicsLayerCA?
WC is a tentative name for prototyping, not a acronym of anything. OK. I should have a better name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210729/0ca15369/attachment-0001.htm>