[Webkit-unassigned] [Bug 228308] [WinCairo] New GraphicsLayer for GPU process mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 09:44:38 PDT 2021


--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 434501
  --> https://bugs.webkit.org/attachment.cgi?id=434501
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434501&action=review

> Source/WebCore/svg/graphics/SVGImage.cpp:283
> +#if !USE(WC) // This code path causes incorrect SVG rendering

Please don't add platform #ifdefs in shared files. If this is wrong, we should figure out how to make it work. Perhaps `!context.hasPlatformContext()` is the wrong check.

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:146
> +#if USE(WC)

"WC" is too short an acronym to be understandable. Please choose something longer.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210729/1708d62b/attachment.htm>

More information about the webkit-unassigned mailing list