[Webkit-unassigned] [Bug 220081] [CMake] Use Apple's ICU as fallback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220081

--- Comment #12 from monson <holymonson at gmail.com> ---
Comment on attachment 416754
  --> https://bugs.webkit.org/attachment.cgi?id=416754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416754&action=review

>> Source/WTF/ChangeLog:8
>> +        Drop mandatory using Apple's ICU on APPLE, instead use it only when no others found.
> 
> I think you could be more descriptive here on what the original behavior is and what was changed to support it.

sure

>> Source/cmake/WebKitFindPackage.cmake:104
>> +            set(ICU_INCLUDE_DIRS ${CMAKE_BINARY_DIR}/ICU/Headers)
> 
> Isn't ICU_INCLUDE_DIRS being set somewhere already? Shouldn't that be respected unless there is a difference?

I don't think so, here ICU_INCLUDE_DIRS is set only when (NOT ICU_FOUND), and this line exists prior to this patch. If it's redundant we should call apple to remove.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210106/4c0a9eed/attachment.htm>