[Webkit-unassigned] [Bug 220081] [CMake] Use Apple's ICU as fallback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220081

Don Olmstead <don.olmstead at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |don.olmstead at sony.com

--- Comment #11 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 416754
  --> https://bugs.webkit.org/attachment.cgi?id=416754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416754&action=review

Overall looks like a good direction for people wanting to build non Apple ports on Apple hardware.

> Source/WTF/ChangeLog:8
> +        Drop mandatory using Apple's ICU on APPLE, instead use it only when no others found.

I think you could be more descriptive here on what the original behavior is and what was changed to support it.

> Source/cmake/WebKitFindPackage.cmake:104
> +            set(ICU_INCLUDE_DIRS ${CMAKE_BINARY_DIR}/ICU/Headers)

Isn't ICU_INCLUDE_DIRS being set somewhere already? Shouldn't that be respected unless there is a difference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210104/e3ba1c7b/attachment.htm>