[Webkit-unassigned] [Bug 191627] [css-grid] Incorrect track sizing when using relative sized items in 'auto' column tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191627

--- Comment #10 from zsun at igalia.com ---
(In reply to Javier Fernandez from comment #8)
> Comment on attachment 421638 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421638&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:2058
> > +    // height value we get from overridingContainingBlockContentLogicalHeight() here, including WTPF::nullopt.
> 
> Nit: s/ WTPF::nullopt/WTF::nullopt
> Nit: I think we could write the comment in a single line.
> 
> > LayoutTests/imported/w3c/ChangeLog:8
> > +        * web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
> 
> Maybe we can comment that the root cause of the failures is what we've got
> in the FIXME comment.

Updated. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210226/0e2ebf56/attachment.htm>