[Webkit-unassigned] [Bug 222084] Crash in IPC::decode(Decoder& decoder, RetainPtr<SecKeychainItemRef>& result)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222084

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Darin Adler from comment #5)
> Comment on attachment 420776 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420776&action=review
> 
> > Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:671
> > +    CFDataRef dref = data.get();
> 
> For future reference, in a case like this there is no need for the local
> variable. It’s totally fine to call data.get() twice.

That's a good point. The compiler will do the work for us since get() is a simple accessor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210219/2d4ac070/attachment-0001.htm>