[Webkit-unassigned] [Bug 222084] Crash in IPC::decode(Decoder& decoder, RetainPtr<SecKeychainItemRef>& result)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 18 17:29:15 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=222084

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 420776
  --> https://bugs.webkit.org/attachment.cgi?id=420776
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420776&action=review

> Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:671
> +    CFDataRef dref = data.get();

For future reference, in a case like this there is no need for the local variable. It’s totally fine to call data.get() twice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210219/061a4c4e/attachment-0001.htm>


More information about the webkit-unassigned mailing list