[Webkit-unassigned] [Bug 234543] Archived subresource loads fail if m_allowedNetworkHosts doesn't include the remote URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234543

--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
(In reply to Matt Woodrow from comment #5)
> (In reply to Alex Christensen from comment #4)
> > Comment on attachment 447746 [details]
> > Patch
> > 
> > This is problematic for many reasons:
> > 1. It doesn't contain a unit test to verify we won't break it in the future.
> 
> Agreed, can you please point me to related tests so that I have an idea
> where to start?
> I saw WKURLSchemeHandler-1.mm, but I'm not sure where to start with loading
> sub resources from an archive.
Yes, that's where to find existing unit tests that use _allowedNetworkHosts.  Search for TEST(LoadWebArchive, HTTPSUpgrade) to see how to load a web archive.  You probably won't need to create a web archive dynamically for this, but you could.  Once you tell WKWebView to load a web archive, it will automatically load sub resources from the web archive.

> > 2. It does not contain a good description of what is going on or under what
> > circumstances this changes behavior.
> 
> Apologies, looks like --update-changelogs changed the description text. Is
> what's in the first comment of the bug sufficient?
It could use more clear language.  "Using WKWebViewConfiguration._allowedNetworkHosts prevents loads from web archives even when the network will not be used" makes it quite clear what is going on.

> Would a change in naming to 'will load from archive' be satisfactory here?
No, I don't think it should be a member of ResourceRequest.  I think it should be another parameter to Page::allowsLoadFromURL

> > 5. There is no link to a radar or something motivating this change.
> 
> Comment 0 links to rdar://83970256, apologies if that's not the correct form
> of linkage.
Sorry, I didn't see that.  That's a good link.  Put it in the Change Log.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211222/62080e6f/attachment.htm>