[Webkit-unassigned] [Bug 234543] Archived subresource loads fail if m_allowedNetworkHosts doesn't include the remote URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234543

--- Comment #5 from Matt Woodrow <m_woodrow at apple.com> ---
(In reply to Alex Christensen from comment #4)
> Comment on attachment 447746 [details]
> Patch
> 
> This is problematic for many reasons:
> 1. It doesn't contain a unit test to verify we won't break it in the future.

Agreed, can you please point me to related tests so that I have an idea where to start?
I saw WKURLSchemeHandler-1.mm, but I'm not sure where to start with loading sub resources from an archive.

> 2. It does not contain a good description of what is going on or under what
> circumstances this changes behavior.

Apologies, looks like --update-changelogs changed the description text. Is what's in the first comment of the bug sufficient?

> 3. Being an "archive load" is not an inherent property of a resource
> request, which ought to be basically just a URL and header fields

Would a change in naming to 'will load from archive' be satisfactory here?

> 4.  It substantially changes the behavior of when scheduleArchiveLoad is
> called, which almost certainly breaks web archive loading somehow.

Indeed it does. I was trying to avoid checking 'will load from archive' during the network host check, in advance of actually scheduling the archive load, since that feels overly fragile. It felt preferable to just schedule, and condition the other behaviour on the result.

I tried to audit possible behaviour changes from calling it early, and couldn't find anything, plus it passes test. It's possible that this is better suited to someone who knows this code.


> 5. There is no link to a radar or something motivating this change.

Comment 0 links to rdar://83970256, apologies if that's not the correct form of linkage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211222/6aba5a5b/attachment.htm>