[Webkit-unassigned] [Bug 234439] Fix Safari-side SafeBrowsing telemetry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234439

--- Comment #4 from Eliot Hsu <eliothsu at apple.com> ---
Comment on attachment 447631
  --> https://bugs.webkit.org/attachment.cgi?id=447631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447631&action=review

>> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1801
>> +            );
> 
> If navigatesFrame is true, then we know that result is ContinueUnsafeLoad::Yes.  This check seems unnecessary.

In the case where the Safe Browsing warning page shows, and the user clicks on the "Learn more..." or "report an error" links instead of "Visit this unsafe website", then `navigatesFrame` and `forMainFrameNavigation` are both true, but `continueUnsafeLoad` is `ContinueUnsafeLoad::No`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211220/3d8c809a/attachment.htm>