[Webkit-unassigned] [Bug 234439] Fix Safari-side SafeBrowsing telemetry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234439

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |achristensen at apple.com
 Attachment #447631|review?                     |review-
              Flags|                            |

--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 447631
  --> https://bugs.webkit.org/attachment.cgi?id=447631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447631&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1801
>          if (navigatesFrame && forMainFrameNavigation) {
>              // The safe browsing warning will be hidden once the next page is shown.
> +            bool continuingUnsafeLoad = WTF::switchOn(result,
> +                [] (ContinueUnsafeLoad continueUnsafeLoad) { return continueUnsafeLoad == ContinueUnsafeLoad::Yes; },
> +                [] (const URL&) { return false; }
> +            );

If navigatesFrame is true, then we know that result is ContinueUnsafeLoad::Yes.  This check seems unnecessary.

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1806
> +            else
> +                dictionary.set("action"_s, String("redirect to url"));

And this seems unreachable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211220/7e1bb4de/attachment.htm>