[Webkit-unassigned] [Bug 234116] [WebAssembly][Modules] Unify memory import handling code in both module loader and JS cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 20 12:45:59 PST 2021


--- Comment #10 from Asumu Takikawa <asumu at igalia.com> ---
(In reply to Yusuke Suzuki from comment #9)
> Ah, what I would like to ask is that, if calleeGroup is non null, then
> wasting that calleeGroup by `m_calleeGroups[i] = WTFMove(newBlock)` sounds
> wrong to me.
> When does it happen and why do we need to replace it with a newly copied one?

Ah ok, I think I understand now. Do you mean that if the calleeGroup exists but it's not runnable, we can instead try to recompile the existing one (probably later when the memory is available) rather than copy a new one in here?

That makes sense to me. I can upload a new patch that implements this later (in Jan, as I've run out of time and will be away from my computer for a while).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211220/a358b10c/attachment.htm>

More information about the webkit-unassigned mailing list