[Webkit-unassigned] [Bug 234116] [WebAssembly][Modules] Unify memory import handling code in both module loader and JS cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234116

--- Comment #9 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 447613
  --> https://bugs.webkit.org/attachment.cgi?id=447613
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447613&action=review

> Source/JavaScriptCore/wasm/WasmModule.cpp:125
> +        // We should only try to copy the group here if it hasn't already been compiled.
> +        if (calleeGroup && !(calleeGroup->compilationFinished() && !calleeGroup->runnable()))
> +            continue;

Ah, what I would like to ask is that, if calleeGroup is non null, then wasting that calleeGroup by `m_calleeGroups[i] = WTFMove(newBlock)` sounds wrong to me.
When does it happen and why do we need to replace it with a newly copied one?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211220/25f9a156/attachment.htm>