[Webkit-unassigned] [Bug 233383] AX: aria-owns in trees results duplicate rows, third level rows not being exposed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233383

--- Comment #20 from Tyler Wilcock <tyler_w at apple.com> ---
(In reply to Tyler Wilcock from comment #19)
> Comment on attachment 446445 [details]
> Patch
> > Source/WebCore/accessibility/AccessibilityObject.cpp:1910
> > +            downcast<AccessibilityObject>(*child).ariaTreeRows(result, parentPath);
> 
> Do we need is<> and downcast<> here? `child` is an AXCoreObject, which
> defines ariaTreeRows. I think we'd only need to downcast if
> AccessibilityObject defined ariaTreeRows and AXIsolatedObject didn't (these
> are the two direct subclasses of AXCoreObject).
> 
> So I think child->ariaTreeRows(result, ancestors); should work OK here.
Oh nevermind, I see, the new method isn't virtual (and shouldn't be -- we wouldn't want that to be part of the AXCoreObject interface).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211209/ae073180/attachment.htm>