[Webkit-unassigned] [Bug 203312] Implement the CSS exponent functions: pow(), sqrt(), hypot()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 30 17:12:54 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=203312

--- Comment #24 from Kevin Turner <kevinturner at utexas.edu> ---
(In reply to Simon Fraser (smfr) from comment #23)
> (In reply to Kevin Turner from comment #22)
> > (In reply to Simon Fraser (smfr) from comment #20)
> > 
> > > > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:154
> > > > +            // The type of a min(), max(), clamp() or hypot() expression is the result of adding the types of its comma-separated calculations
> > > > +            return CalculationCategory::Other;
> > > 
> > > I can't tell if the line you copied above with the comment represents a TODO
> > > or correct behavior.
> > 
> > If you are referring to the comment of "The type of a min(), max()...", I
> > was attempting to keep this comment up to date since I am adding 'hypot()'
> > with this commit. Do you think we should remove this comment?
> 
> I don't know! Code above does more complex things to figure out the
> category. Do min max, clamp etc need to also do something more complex?

>From my understanding of the spec for these functions is that hypot() should have the same category as min, max and clamp and pow() and sqrt() should behave purely off of numbers.

I realize now though that in rebasing this the case statements for ::other are repeated needlessly. Updated patch incoming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210831/1934e97e/attachment-0001.htm>


More information about the webkit-unassigned mailing list