[Webkit-unassigned] [Bug 203312] Implement the CSS exponent functions: pow(), sqrt(), hypot()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 30 16:34:33 PDT 2021


--- Comment #23 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
(In reply to Kevin Turner from comment #22)
> (In reply to Simon Fraser (smfr) from comment #20)
> > > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:154
> > > +            // The type of a min(), max(), clamp() or hypot() expression is the result of adding the types of its comma-separated calculations
> > > +            return CalculationCategory::Other;
> > 
> > I can't tell if the line you copied above with the comment represents a TODO
> > or correct behavior.
> If you are referring to the comment of "The type of a min(), max()...", I
> was attempting to keep this comment up to date since I am adding 'hypot()'
> with this commit. Do you think we should remove this comment?

I don't know! Code above does more complex things to figure out the category. Do min max, clamp etc need to also do something more complex?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210830/782ecae2/attachment.htm>

More information about the webkit-unassigned mailing list