[Webkit-unassigned] [Bug 217365] [Payment Request] Calling PaymentRequest's show() should consume user activation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217365

--- Comment #9 from Marcos Caceres <marcos at marcosc.com> ---
Comment on attachment 436443
  --> https://bugs.webkit.org/attachment.cgi?id=436443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436443&action=review

>> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:375
>> +    if (window && !window->consumeTransientActivation()) {
> 
> Should it be:
> if (!window || !window->consumeTransientActivation()) {
> }

Yes. You are right. I was unsure if I should treat a nullprt window as a different kind of error. Will update.

>> LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-is-showing.https.html:7
>> +<meta name="timeout" content="long" />
> 
> I am guessing this is resyncing our copy of WPT tests with upstream.
> If so, can you update the change log?

Will do!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210826/1f044901/attachment.htm>