[Webkit-unassigned] [Bug 217365] [Payment Request] Calling PaymentRequest's show() should consume user activation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217365

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #436443|review?                     |review+
              Flags|                            |

--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 436443
  --> https://bugs.webkit.org/attachment.cgi?id=436443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436443&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:375
> +    if (window && !window->consumeTransientActivation()) {

Should it be:
if (!window || !window->consumeTransientActivation()) {
}

> LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-is-showing.https.html:7
> +<meta name="timeout" content="long" />

I am guessing this is resyncing our copy of WPT tests with upstream.
If so, can you update the change log?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210826/e8a22635/attachment-0001.htm>