[Webkit-unassigned] [Bug 229415] AX: Return radiobuttons part of ad-hoc radiogroups from AX search queries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229415

--- Comment #6 from Tyler Wilcock <tyler_w at apple.com> ---
Thanks for the review!

> objectIsRadioButtonInDifferentGroup -> areRadioButtonsInDifferentGroups or areRadioButtonsInSameGroup ???

The semantics of this function can't be the same as what one would think with `areRadioButtonsInDifferentGroups`, as that name implies the function returns false if either object is not a radio button, but we want to return true if the `referenceObject` is not a radio button and `axObject` is.

I'll go with isRadioButtonInDifferentAdhocGroup for now, but if you have other ideas let me know.

> however, are we guaranteed to have an element() if it's already a radio button?

Yeah, that seems reasonable. I'll remove the check.

> Are we covering the case of radiogroup containers in a separate test?

accessibility/mac/search-predicate.html tests a search for role=radiogroup containers:

https://github.com/WebKit/WebKit/blob/989ff515ce6e103271072dd1b397ac43572a910c/LayoutTests/accessibility/mac/search-predicate.html#L225

Is that satisfactory, or are you looking for something here too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210824/e6fbad10/attachment.htm>