[Webkit-unassigned] [Bug 229152] REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229152

--- Comment #12 from Philippe Normand <pnormand at igalia.com> ---
(In reply to Michael Catanzaro from comment #11)
> I think we'll need to run apply-build-revision-to-files.py first, since
> updating @BUILD_REVISION@ is the first step that needs to happen, *then* do
> CMake configure in a separate step. Yes? Because the way it is now, if we
> switch from ${BUILD_REVISION} to @BUILD_REVISION@, then CMake is going to
> replace @BUILD_REVISION@ before apply-build-revision-to-files.py runs, and
> then the python script will do nothing. So we'd need to switch from *.in
> suffix to *.in.in. Phil, do you agree?

The python script actually has logic now to restore the revision=${BUILD_REVISION} template in already expanded .pc files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210817/11f58dab/attachment-0001.htm>