[Webkit-unassigned] [Bug 177934] [SOUP] Add support for preconnect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177934

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 426541
  --> https://bugs.webkit.org/attachment.cgi?id=426541
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426541&action=review

>> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:256
>> +#if !USE(SOUP2)
> 
> What about && ENABLE(SERVER_PRECONNECT) ?

SERVER_PRECONNECT is enabled unconditionally when building with soup3

>> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:478
>> +}
> 
> I'd suggest using makeScopeExit for the clearRequest() call. However I am not sure whether the RefPtr::deref is executed after it so we can leave it as it just in case.

clearRequest should happen before the dispatchDidCompleteWithError.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210422/9ecdb45c/attachment.htm>