[Webkit-unassigned] [Bug 177934] [SOUP] Add support for preconnect
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 22 05:13:32 PDT 2021
https://bugs.webkit.org/show_bug.cgi?id=177934
Sergio Villar Senin <svillar at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #426541|review? |review+
Flags| |
--- Comment #9 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 426541
--> https://bugs.webkit.org/attachment.cgi?id=426541
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=426541&action=review
> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:256
> +#if !USE(SOUP2)
What about && ENABLE(SERVER_PRECONNECT) ?
> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:463
> +#if !USE(SOUP2)
Ditto
> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:478
> +}
I'd suggest using makeScopeExit for the clearRequest() call. However I am not sure whether the RefPtr::deref is executed after it so we can leave it as it just in case.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210422/7630b45a/attachment.htm>
More information about the webkit-unassigned
mailing list