[Webkit-unassigned] [Bug 216607] webkitfullscreenchange does not fire for shadow DOM elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216607

--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 409921
  --> https://bugs.webkit.org/attachment.cgi?id=409921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409921&action=review

> LayoutTests/fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html:41
> +const button = document.querySelector('button');
> +button.onclick = goFullscreen;

Like I clarified above, there is no need for this event handler to be defined in the script.

> LayoutTests/fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html:50
> +} else {
> +    document.write('To test manually, click "Enter Fullscreen" above.');
> +}

Nit: There should be no curly brackets around document.write since it's a single one statement:
https://bugs.webkit.org/show_bug.cgi?id=216607

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200928/8a9a1fa5/attachment-0001.htm>