[Webkit-unassigned] [Bug 216607] webkitfullscreenchange does not fire for shadow DOM elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216607

--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Tetsuharu Ohzeki from comment #13)
> (In reply to Ryosuke Niwa from comment #11)
> > Comment on attachment 409844 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=409844&action=review
> > > LayoutTests/fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html:54
> > > +let button = document.querySelector('button');
> > > +button.onclick = goFullscreen;
> > 
> > Just add the event handler (onclick) in the HTML above.
>  
> This is complex by the order of script execution because `goFullscreen` is
> not defined at `<button onclick=""/>` specified.

There is nothing complex about this. Event handlers are not evaluated until it's triggered so it's perfectly fine to refer to a function that's defined later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200928/792fc2f6/attachment.htm>