[Webkit-unassigned] [Bug 216834] [macOS] Issue sandbox extension for the diagnostic daemon

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216834

--- Comment #11 from Per Arne Vollan <pvollan at apple.com> ---
(In reply to mitz from comment #10)
> Comment on attachment 409385 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409385&action=review
> 
> >> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211
> >> +    static bool isInternal = !stat("/AppleInternal", &st);
> > 
> > I think it might be better to do:
> > 
> > static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal", FileSystem::ShouldFollowSymbolicLinks::No);
> 
> Either way it’s not the recommended way to test whether a computer is
> running the Apple-internal version of macOS. See OSVariantSPI.h in WTF.

Ah, thanks! I will look into that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200923/1a6bb35f/attachment.htm>