[Webkit-unassigned] [Bug 216834] [macOS] Issue sandbox extension for the diagnostic daemon

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216834

mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mitz at webkit.org

--- Comment #10 from mitz at webkit.org ---
Comment on attachment 409385
  --> https://bugs.webkit.org/attachment.cgi?id=409385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409385&action=review

>> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211
>> +    static bool isInternal = !stat("/AppleInternal", &st);
> 
> I think it might be better to do:
> 
> static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal", FileSystem::ShouldFollowSymbolicLinks::No);

Either way it’s not the recommended way to test whether a computer is running the Apple-internal version of macOS. See OSVariantSPI.h in WTF.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200923/054decb3/attachment-0001.htm>