[Webkit-unassigned] [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216172

--- Comment #35 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 413795
  --> https://bugs.webkit.org/attachment.cgi?id=413795
Use symbols as identifiers, v14

View in context: https://bugs.webkit.org/attachment.cgi?id=413795&action=review

> JSTests/stress/class-fields-harmony.js:922
> +}

As I commented above, I think it's valuable have tests asserting that we are setting function name properly. I think there are at least 2 new cases we'd like to include:

1. Computed field with some function expression on assignment.
2. Computed field with class expression on assignment.

So we'd like to assert for those cases `assertSame(c[x].name, <x evaluation to function name>)`.
I'd personally would include cases where `x` is not a trivial primitive, but also an object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201111/61448753/attachment.htm>