[Webkit-unassigned] [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216172

--- Comment #34 from Caio Lima <ticaiolima at gmail.com> ---
(In reply to Xan Lopez from comment #24)
> (In reply to Caio Lima from comment #22)
> 
> About the test, there is one in test262 for static fields that verifies this
> works, but it won't land with this patch. We should add a test262 test for
> instance fields too, but it also would not land with this patch, right? I'd
> say doing that is enough coverage, but I could add a test for it locally if
> you think that's important.

The problem with relying on Test262 coverage is that we don't run them on EWS yet. This makes our life harder to know when we break things not included on stress tests, since we will only figure out that they broke after landing it.

I think it's a very good practice try to have stress test to increase coverage of every change we make on a patch, with a few exceptions of cases where it's hard to reproduce them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201111/220e7086/attachment.htm>