[Webkit-unassigned] [Bug 218657] [macOS] Add IOKIt message filtering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218657

--- Comment #6 from Per Arne Vollan <pvollan at apple.com> ---
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 413465 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413465&action=review
> 
> I had a few questions, but looks good. r=me
> 
> > Source/WebKit/ChangeLog:9
> > +        Like on iOS, the WebContent process on macOS should have IOKit message filtering as well.
> 
> No need for "as well" at the end (since you say "Like on iOS, ...")
> 

Will fix!

> > Source/WebKit/ChangeLog:15
> > +        * WebProcess/com.apple.WebProcess.sb.in:
> 
> Should we be making similar changes to the GPU Process sandbox?
> 

That is a good point. Would you be OK with doing this in a separate patch?

> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-139
> > -        (iokit-registry-entry-class "AppleGraphicsControlClient")
> 
> So we do NOT need AppleGraphicsControlClient?

Ah, good catch! Will fix.

Thanks for reviewing!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201106/95df453d/attachment.htm>