[Webkit-unassigned] [Bug 218657] [macOS] Add IOKIt message filtering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218657

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #413465|review?                     |review+
              Flags|                            |

--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 413465
  --> https://bugs.webkit.org/attachment.cgi?id=413465
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413465&action=review

I had a few questions, but looks good. r=me

> Source/WebKit/ChangeLog:9
> +        Like on iOS, the WebContent process on macOS should have IOKit message filtering as well.

No need for "as well" at the end (since you say "Like on iOS, ...")

> Source/WebKit/ChangeLog:15
> +        * WebProcess/com.apple.WebProcess.sb.in:

Should we be making similar changes to the GPU Process sandbox?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-139
> -        (iokit-registry-entry-class "AppleGraphicsControlClient")

So we do NOT need AppleGraphicsControlClient?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201106/dd6b9f34/attachment-0001.htm>