[Webkit-unassigned] [Bug 218441] Conditionally disable the patch validation step

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218441

--- Comment #3 from Angelos Oikonomopoulos <angelos at igalia.com> ---
(In reply to Aakash Jain from comment #2)
> Comment on attachment 412908 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412908&action=review
> 
> > Tools/ChangeLog:11
> > +        Note that the skip_validation parameter cannot be supplied remotely, so
> 
> This build property can be supplied while using 'buildbot try' command
> (which ews-app uses). So, this note doesn't seems accurate.

My bad. 'buildbot try' can of course connect to a remote server instance. What I meant to say is that, AFAIU, Try_Userpass uses a separate set of auth credentials, so that one can only set skip_validation by going through the ews-app.

If that's not the case, do you have a suggestion for good way to skip patch validation for testing setups?

> > Tools/CISupport/ews-build/steps.py:661
> > +        return int(self.getProperty('skip_validation', 0)) == 0
> 
> should we make this property boolean instead of 0/1? Something like:
> 
> return not self.getProperty('skip_validation', False)

I actually selected this because it's probably easier for the user to figure out how to specify a boolean property to the buildbot cli client but, as it's unlikely this would be used directly by someone, using a bool seems like an improvement. I'll submit an updated patch.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201104/f4fef3d9/attachment-0001.htm>