[Webkit-unassigned] [Bug 218441] Conditionally disable the patch validation step

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218441

--- Comment #2 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 412908
  --> https://bugs.webkit.org/attachment.cgi?id=412908
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412908&action=review

> Tools/ChangeLog:11
> +        Note that the skip_validation parameter cannot be supplied remotely, so

This build property can be supplied while using 'buildbot try' command (which ews-app uses). So, this note doesn't seems accurate.

> Tools/CISupport/ews-build/steps.py:661
> +        return int(self.getProperty('skip_validation', 0)) == 0

should we make this property boolean instead of 0/1? Something like:

return not self.getProperty('skip_validation', False)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201102/bdeeb34b/attachment.htm>