[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176119

--- Comment #37 from Jan-Michael Brummer <jan.brummer at tabos.org> ---
(In reply to Carlos Garcia Campos from comment #36)
> (In reply to Jan-Michael Brummer from comment #34)
> > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:5082
> > > > +    send(Messages::WebPageProxy::IsPageMutedDidChange());
> > > 
> > > Do we really need to get notified back by the web process, I thought this
> > > was because setting muted might fail, but since this is called
> > > unconditionally, and the UI process is getting the value already set there,
> > > I don't think we need this.
> > At least this way we know the initial value for a page or in case the page
> > mute is changed somewhere else.
> 
> I don't understand. The mute value is always set by the UI process, either
> calling setMuted or as initial parameter, so the initial value is the one we
> have in the WebPageProxy. Or did I miss anything? I don't know what you mean
> by changed somewhere else. WebPage::setMuted() is only called by the message
> handler when the IPC message is received and with the initial value. In both
> cases it's the value just set by the Ui process.
You are right, I've mixed it up: It is only set by setMuted and the initial value. So what exactly are you proposing here? It's my second contribution here and i'm not yet 100% familiar with the whole code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200513/87756aa2/attachment-0001.htm>