[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 13 04:46:37 PDT 2020


--- Comment #36 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Jan-Michael Brummer from comment #34)
> > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:5082
> > > +    send(Messages::WebPageProxy::IsPageMutedDidChange());
> > 
> > Do we really need to get notified back by the web process, I thought this
> > was because setting muted might fail, but since this is called
> > unconditionally, and the UI process is getting the value already set there,
> > I don't think we need this.
> At least this way we know the initial value for a page or in case the page
> mute is changed somewhere else.

I don't understand. The mute value is always set by the UI process, either calling setMuted or as initial parameter, so the initial value is the one we have in the WebPageProxy. Or did I miss anything? I don't know what you mean by changed somewhere else. WebPage::setMuted() is only called by the message handler when the IPC message is received and with the initial value. In both cases it's the value just set by the Ui process.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200513/3f713e42/attachment.htm>

More information about the webkit-unassigned mailing list