[Webkit-unassigned] [Bug 209579] Escaped UTF-8 not parsed correctly with icu 52

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209579

--- Comment #8 from Darin Adler <darin at apple.com> ---
(In reply to Milan Crha from comment #7)
> if WebKit itself doesn't require newer ICU, it
> should work properly with the older too

That’s something we don’t agree on. WebKit often moves dependency forward and it’s a non-goal to work around bugs in very old versions of dependent libraries.

. In other words, if WebKit expects
> certain functionality or behaviour of some of its dependencies, which is
> available only since some version, then it's WebKit, which should claim that
> it requires such version of the dependencies. Just like when using new API
> from the dependency

Yes, the WebKit package should clearly state the dependency on a newer version of ICU. Let's fix that!

> The other way around is to make the software working in the older versions
> as well.

Easier said than done.

> Looking into Mike's change, it's quite trivial. I do not know the details,
> but I'd even use 'unsigned char' for the 'b0' directly, to not have it
> defined as 'char'. There's always a problem with the highest bit when it
> comes to cast between signed and unsigned types.

I’m not sure I agree. Is this the only problem with older ICU? We don’t test with those older versions and there is no guarantee this is sufficient.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200327/38e70ba0/attachment.htm>