[Webkit-unassigned] [Bug 209579] Escaped UTF-8 not parsed correctly with icu 52

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209579

Milan Crha <mcrha at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcrha at redhat.com

--- Comment #7 from Milan Crha <mcrha at redhat.com> ---
(In reply to Darin Adler from comment #6)
> If updating WebKit I suggest also updating ICU to something newer than 7
> years old.

I agree with this, though if WebKit itself doesn't require newer ICU, it should work properly with the older too. In other words, if WebKit expects certain functionality or behaviour of some of its dependencies, which is available only since some version, then it's WebKit, which should claim that it requires such version of the dependencies. Just like when using new API from the dependency.

The other way around is to make the software working in the older versions as well.

Looking into Mike's change, it's quite trivial. I do not know the details, but I'd even use 'unsigned char' for the 'b0' directly, to not have it defined as 'char'. There's always a problem with the highest bit when it comes to cast between signed and unsigned types.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200327/a30d2157/attachment.htm>