[Webkit-unassigned] [Bug 208507] New: Test media/video-controls-toggling.html is failing for GTK since r257299

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 3 03:28:31 PST 2020


            Bug ID: 208507
           Summary: Test media/video-controls-toggling.html is failing for
                    GTK since r257299
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: calvaris at igalia.com, jer.noble at apple.com

This has started to fail for GTK since we switched to use adwaita media controls, but I think this was passing by coincidence. The test itself is wrong and that's probably the reason why it fails in the other platforms too. The test expects that the changes that happen after removing the controls attribute from video element are sync, but they aren't because a mutation observer is used by media controls script. Then it assumes that panel display property is set to none after controls attribute is removed, but we are actually removing the media controls tree from the DOM in that case so the panel is null at that point. This worked in GTK before because all those checks that were supposed to happen after removing the controls were done before the handleControlsChange() was called.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200303/d5f1bee8/attachment.htm>

More information about the webkit-unassigned mailing list