[Webkit-unassigned] [Bug 213278] IPC/Decoder.h and IPC/Encoder.h need every WTF::EnumTraits<> specialization included before they are included

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 12:00:11 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=213278

--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Created attachment 402580

  --> https://bugs.webkit.org/attachment.cgi?id=402580&action=review

Reproduce the build failure

This patch reproduces the build failure after removing #include <WebCore/ContextMenuItem.h> from Decoder.h/Encoder.h and adding it to Source/WebKit/Shared/WebContextMenuItemData.cpp.  (Adding it to WebContextMenuItemData.cpp doesn't actually make any difference, so this change could also be left out.  It's what I would expect to work, but doesn't.)

The call to WTF::isValidEnum<E>() when wants the template specialization defined is happening in Encoder.h (and Decoder.h), but both of those headers are included by an earlier *.cpp file in UnifiedSource24.cpp for WebKit.

So one solution might be to remove WebContextMenuItemData.cpp as supporting Unified Sources.  I have not tried that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200623/6856db72/attachment-0001.htm>


More information about the webkit-unassigned mailing list